Update hellofresh scraper #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…can be scaled to 1 portion. The hellofresh website seems to have been updated and the json+ld data now contains the correct information for the given yield. Update both hellofresh tests with the latest html for the same URLs and fix changes in output due to updated html.
|
The changes here look good to me 👍 I'm beginning to take a look into the unit test failures on MacOS for Python version 3.7 and 3.8 to see what's going on there. |
|
My current best-guess is that the unit test failures are something to do with |
jayaddison
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the special handling of recipes that can be scaled to 1 portion that was introduced due to #527.
It looks like the issue in the embedded ld+json have been fixed and the ingredient quantities in the data are consistent with the yield.
I've updated both tests for the scraper with the latest html for the same recipes so they pass.
I also checked the updated scraper against some of the URLs given in #527 and it seems to work fine for them too.
This should close #777.