fixed reishunger.de parser #352 #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixed tests to assert for equality |
jayaddison
reviewed
Oct 2, 2022
…n for each -- except for special 'preparations' steps which should output multiple instructions
|
the latest change you made looses the special instructions that are provided for different cooking methods, that's the reason i did not implement it before, feel free to leave it like this but wanted to let you know. |
|
Thanks for noticing that - that's a bug. Pushing a fix in a moment (should be using |
|
The numbered step headings included in the instructions list didn't seem ideal - I've pushed eaf05d0 to filter those out, and will merge this soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reishunger.de has two different formats, in one it offers different cooking methods in the other it does not.
This PR
fixes #352