fix: avoid overriding Transform.destroy() method

[curbengh]

fix compatibility with Node 14

hexojs/hexo#4260 (comment)

[coveralls]

Coverage decreased (-0.009%) to 97.017% when pulling 3dd882f on curbengh:cache-destroy into 31f74a5 on hexojs:master.

[curbengh]

Tested Node 10, 12, 13 and 14 on dummy blog using hexo g --debug, no errors and resolved empty files issue.

[stevenjoezhang]

Confirm that it is working properly now.
However, after removing the definition of destroy method, cacheStream._cache will not be deleted, which means that the resource is actually processed by JavaScript garbage collection, not cacheStream.destroy(); here:

https://github.com/hexojs/hexo/blob/b60f815b975178ee1c907a92e5a1403830e56f37/lib/plugins/console/generate.js#L68

[SukkaW]

[Edited]

[SukkaW]

which means that the resource is actually processed by JavaScript garbage collection

Will it cause memory leak?

Update

Although memory usage raises a little bit, but no memory leak detected (tested in hexojs/hexo#4264).

[SukkaW]

Verified in hexojs/hexo#4264

[curbengh]

cacheStream._cache will not be deleted...the resource is actually processed by JavaScript garbage collection

Meaning destroy() triggers the garbage collection to clean up _cache? Will _cache get cleaned up and not cause memory leakage?

Although memory usage raises a little bit, but no memory leak detected

I assume destroy() is working then?

[SukkaW]

I assume destroy() is working then?

Yes. If it is not working, there might be huge memory consumption.