Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: incompatible with Node 14 #4285

Merged
merged 7 commits into from May 14, 2020
Merged

chore: incompatible with Node 14 #4285

merged 7 commits into from May 14, 2020

Conversation

curbengh
Copy link
Contributor

What does it do?

Hexo 4 is incompatible with Node 14. Compatibility fixes have been merged but will only be released in v5.0.0 and not backported.

v4.2.1 does not include commits merged into master since v4.2.0 (c0bf222). It only includes commits made by this PR. Please note this PR's base branch is 4.2.1 not master.

I'll release 4.2.1 after this PR is merged.

ref: #4260

How to test

git clone -b 4.2.1 https://github.com/curbengh/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@curbengh curbengh requested a review from a team April 30, 2020 03:09
@curbengh curbengh mentioned this pull request Apr 30, 2020
@coveralls
Copy link

coveralls commented Apr 30, 2020

Coverage Status

Coverage remained the same at 97.092% when pulling 3ee7fb5 on curbengh:4.2.1 into c0bf222 on hexojs:4.2.1.

@stevenjoezhang stevenjoezhang linked an issue Apr 30, 2020 that may be closed by this pull request
yoshinorin
yoshinorin previously approved these changes May 5, 2020
@SukkaW
Copy link
Member

SukkaW commented May 5, 2020

@curbengh You can merge this PR and release 4.2.1 any time you want.

@yoshinorin
Copy link
Member

yoshinorin commented May 9, 2020

@curbengh, @SukkaW, @hexojs/core

Some users requests hotfix (v4.2.1) .

As they say, I think we should release hotfix that includes hexojs/hexo-fs#60 & hexojs/hexo-util#195.
Now, I'm trying to create hexo-util 1.9.1 & hexo-fs 2.0.1. They will includes hexojs/hexo-fs#60 & hexojs/hexo-util#195.

@yoshinorin
Copy link
Member

yoshinorin commented May 9, 2020

@hexojs/core

I created pull requests for backport.

hexojs/hexo-util#205
hexojs/hexo-fs#70

I'm going to publish hexo-util 1.9.1 & hexo-fs 2.0.1.
After that, I'm going to publish hexo 4.2.1 based on this PR.


BTW, I want to know how to publish the legacy (backport) version of npm.
The below command is correct ??

$ npm publish --tag=<git tag>

// example
$ npm publish --tag=4.2.1

PS:

I tested on local env like below.

"dependencies": {
  "hexo": "git+https://github.com/YoshinoriN/hexo.git#4.2.1-test",

Above branch is here.

It seems works well on Node 8.17.0, 10.18.0, 12.11.0 and 14.2.0. (all env are on my local machine)

@yoshinorin
Copy link
Member

yoshinorin commented May 13, 2020

I published hexo-util 1.9.1

@hexojs/core
Does someone would you please approve hexojs/hexo-fs#70 & hexojs/hexo-fs#71?

@yoshinorin
Copy link
Member

yoshinorin commented May 13, 2020

@curbengh @hexojs/core
We can publish 4.2.1 that includes backport from 5.0.0. (backport are included in hexo-fs: 2.0.1 & hexo-util: 1.9.1)

CI are pass with node 14.
Would you please review again?

I'm going to publish 4.2.1 after merge this PR.

Thank you :)

@yoshinorin yoshinorin requested review from tomap, SukkaW and a team May 13, 2020 15:37
@SukkaW
Copy link
Member

SukkaW commented May 13, 2020

LGTM! The PR could be merged after the release note & news are ready.

@yoshinorin
Copy link
Member

I published 4.2.1 & test it on my local machine (node 14.2.0).

It works :)
We can close this issue 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hexo deploy error
6 participants