fix: avoid overriding Transform.destroy() method

- fix compatibility with Node 14
hexojs · Apr 24, 2020 · dca1360 · dca1360
1 parent 5b14fd2
commit dca1360
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/lib/cache_stream.js b/lib/cache_stream.js
@@ -18,10 +18,6 @@ CacheStream.prototype._transform = function(chunk, enc, callback) {
   callback();
 };
 
-CacheStream.prototype.destroy = function() {
-  this._cache.length = 0;
-};
-
 CacheStream.prototype.getCache = function() {
   return Buffer.concat(this._cache);
 };

diff --git a/test/cache_stream.spec.js b/test/cache_stream.spec.js
@@ -22,10 +22,18 @@ describe('CacheStream', () => {
   });
 
   it('destroy', () => {
+    const src = new Readable();
     const cacheStream = new CacheStream();
-    cacheStream._cache = [Buffer.alloc(1)];
+    const content = Buffer.from('test');
+
+    src.push(content);
+    src.push(null);
+    src.pipe(cacheStream);
 
     cacheStream.destroy();
-    cacheStream._cache.should.have.length(0);
+
+    cacheStream.on('close', () => {
+      cacheStream.getCache().length.should.eql(0);
+    });
   });
 });