ci: improve backport PR title and body #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #420 +/- ##
=======================================
Coverage 80.43% 80.43%
=======================================
Files 32 32
Lines 5756 5756
=======================================
Hits 4630 4630
Misses 718 718
Partials 408 408 ☔ View full report in Codecov by Sentry. |
|
What about using a fork of tibdex/backport that include my PR tibdex/backport#109 and also embed the release-please commit override ? |
The previous templates were not compatible with our usage: - The title was prefixed with `[Backport release-1.x]` which broke `release-please` - The body was empty besides the comment about backporting. By default we use the PR body as the commit message, so we should include the relevant details here.
apricote
force-pushed
the
backport-config
branch
from
73b758f
to
86c1251
Compare
Done! |
jooola
approved these changes
Apr 22, 2024
|
Will mark this PR as backport to test the new templates. |
apricote
added
the
backport release-1.x
github-actions bot
pushed a commit
that referenced
this pull request
Apr 22, 2024
The previous templates were not compatible with our usage: - The title was prefixed with `[Backport release-1.x]` which broke `release-please` - The body was empty besides the comment about backporting. By default we use the PR body as the commit message, so we should include the relevant details here. (cherry picked from commit 2e44ada)
apricote
added a commit
that referenced
this pull request
Apr 22, 2024
The previous templates were not compatible with our usage: - The title was prefixed with `[Backport release-1.x]` which broke `release-please` - The body was empty besides the comment about backporting. By default we use the PR body as the commit message, so we should include the relevant details here. --- Backport 2e44ada from #420. Co-authored-by: Julian Tölle <julian.toelle@hetzner-cloud.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous templates were not compatible with our usage:
[Backport release-1.x]which brokerelease-please