Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: improve backport PR title and body [Backport release-1.x] #421

Merged
merged 1 commit into from Apr 22, 2024

Conversation

github-actions[bot]
Copy link
Contributor

The previous templates were not compatible with our usage:

  • The title was prefixed with [Backport release-1.x] which broke release-please
  • The body was empty besides the comment about backporting. By default we use the PR body as the commit message, so we should include the relevant details here.

Backport 2e44ada from #420.

BEGIN_COMMIT_OVERRIDE
ci: improve backport PR title and body
END_COMMIT_OVERRIDE

The previous templates were not compatible with our usage:

- The title was prefixed with `[Backport release-1.x]` which broke
`release-please`
- The body was empty besides the comment about backporting. By default
we use the PR body as the commit message, so we should include the
relevant details here.

(cherry picked from commit 2e44ada)
@github-actions github-actions bot requested a review from a team as a code owner April 22, 2024 09:50
@apricote
Copy link
Member

New templates work well!

@apricote apricote merged commit 54ee67e into release-1.x Apr 22, 2024
@apricote apricote deleted the backport-420-to-release-1.x branch April 22, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant