12124: Fix namespace on kubeconfig error #12979
Merged
+11
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/S
CalvinKrist
force-pushed
the
fix-namespace-on-kube-error
branch
2 times, most recently
from
7aa01a3
to
14b80f1
Compare
Signed-off-by: Calvin Krist <calvin.krist@yahoo.com>
CalvinKrist
force-pushed
the
fix-namespace-on-kube-error
branch
from
14b80f1
to
214fb6e
Compare
3 tasks
NickJosevski
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
The code fix is the same #12126 by
@alex-hunt-materialize
I verified the test detects the issue by commenting out the fix, and running the test, screenshot here:
Then restoring fix, test is successful, screenshot here:
|
@joejulian If you're happy that the testing I did is enough, and you remember your comment here This PR can be approved (when suitable) and the other one closed. |
joejulian
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Closes #12124
When the kubeconfig is missing or invalid, the namespace defaults to default instead of the correct namespace. Ensure that on error reading the config, the correct namespace is still returned.
Special notes for your reviewer:
Copies #12126 but adds a unit test.
If applicable: