Allow setting namespace in helm template without a kubeconfig
#12126
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you don't have a working kubeconfig, `helm template` does not respect the `--namespace` option. It gets set on the settings object, but does not get returned. `helm template` should not require a working kubeconfig or any communication with a kubernetes cluster. Signed-off-by: Alex Hunt <alex.hunt@materialize.com>
pull-request-size
bot
added
the
size/XS
joejulian
requested changes
Mar 26, 2024
There was a problem hiding this comment.
After giving this some thought, this seems correct. There is another flag in this struct that overrides the environment variable.
Line 106 in f8da927
We can't do namespace the same way, though, because the kubeconfig flags will need parsed to get the default namespace from the kubeconfig (if set and env is not). This seems like the appropriate place to process this override.
I would like to see this added to the unit test though.
3 tasks
|
@joejulian I copied their fix and added a unit test here #12979. I confirmed that without the fix being present the test fails. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If you don't have a working kubeconfig,
helm templatedoes not respect the--namespaceoption, instead silently ignoring it and using "default". It gets set on the settings object, but does not get returned by theNamespace()method.helm templateshould not require a working kubeconfig or any communication with a kubernetes cluster, as it is only generating templates.This PR adds a fallback to return the already set namespace field, rather than ignoring the user's intentions and returning "default".
Closes #12124
Special notes for your reviewer:
If applicable: