Support if the help is either stdout or stderr #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a change in Cobra which causes the help message to be printed to stderr instead of stdout. See spf13/cobra#922 In preparation for a future upgrade to a new version of Cobra, this commit allows the tests to support both cases. Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
marckhouzam
added a commit
to VilledeMontreal/acceptance-testing
that referenced
this pull request
Jan 1, 2020
This reverts commit 187a774. Cobra has reverted the change that had the help message go to stderr: spf13/cobra#1004 Considering what allowed to notice this regression in Cobra was the failure of Helm's acceptance-testing repo, I prefer to continue have the test fail if the help ever goes to stderr.
marckhouzam
added a commit
to VilledeMontreal/acceptance-testing
that referenced
this pull request
Jan 1, 2020
This reverts commit 187a774. Cobra has reverted the change that had the help message go to stderr: spf13/cobra#1004 Considering what allowed to notice this regression in Cobra was the failure of Helm's acceptance-testing repo, I prefer to continue have the test fail if the help ever goes to stderr. Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
marckhouzam
added a commit
that referenced
this pull request
Feb 2, 2020
This reverts commit 187a774. Cobra has reverted the change that had the help message go to stderr: spf13/cobra#1004 Considering what allowed to notice this regression in Cobra was the failure of Helm's acceptance-testing repo, I prefer to continue have the test fail if the help ever goes to stderr. Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
akashshinde
added a commit
to akashshinde/acceptance-testing
that referenced
this pull request
Apr 8, 2020
* 'master' of github.com:helm/acceptance-testing: (41 commits) New helm global flags --kube-token and --kube-apiserver Add completion tests for release names Add completion tests for plugin completion Test kube-context completion without assuming kubectl Group related tests together Don't use a plugin named 'template' for completion Revert "Support if the help is either stdout or stderr (helm#64)" Update namespace flag tests for zsh Some fixes in preparation for plugin completion Make completion tests work with completion in Go Add completion test on centos Fix helm repo update not working Fix some of the KFAILs Fix the ZFAIL cases Support if the help is either stdout or stderr (helm#64) Print ERROR instead of FAIL Use linux image for docker (helm#60) fix: Helm 3 now supports the -c flag helm plugin 'remove' is now 'uninstall' maint: build helm 3 from master ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a change in Cobra which causes the help message to be printed
to stderr instead of stdout.
See spf13/cobra#922
In preparation for a future upgrade to a new version of Cobra,
this commit allows the tests to support both cases.
Signed-off-by: Marc Khouzam marc.khouzam@montreal.ca