Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't set SO_REUSEPORT on Windows (#23947) [5.3.z] #25397

Merged
merged 1 commit into from Sep 7, 2023
Merged

Don't set SO_REUSEPORT on Windows (#23947) [5.3.z] #25397

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 17 additions & 2 deletions ...ngine/src/main/java/com/hazelcast/internal/tpcengine/nio/NioAsyncServerSocketOptions.java
View file
Open in desktop
Expand Up @@ -16,14 +16,17 @@

package com.hazelcast.internal.tpcengine.nio;

import com.hazelcast.internal.tpcengine.net.AsyncSocketOptions;
import com.hazelcast.internal.tpcengine.Option;
import com.hazelcast.internal.tpcengine.net.AsyncSocketOptions;
import com.hazelcast.internal.tpcengine.util.OS;

import java.io.IOException;
import java.io.UncheckedIOException;
import java.net.SocketOption;
import java.net.StandardSocketOptions;
import java.nio.channels.ServerSocketChannel;
import java.util.HashSet;
import java.util.Set;

import static com.hazelcast.internal.tpcengine.util.Preconditions.checkNotNull;
import static com.hazelcast.internal.tpcengine.util.ReflectionUtil.findStaticFieldValue;
Expand All @@ -36,6 +39,12 @@ public class NioAsyncServerSocketOptions implements AsyncSocketOptions {
// This option is available since Java 9, so we need to use reflection.
private static final SocketOption<Boolean> STD_SOCK_OPT_SO_REUSEPORT
= findStaticFieldValue(StandardSocketOptions.class, "SO_REUSEPORT");
private static final Set<SocketOption<?>> WINDOWS_UNSUPPORTED_OPTIONS;

static {
WINDOWS_UNSUPPORTED_OPTIONS = new HashSet<>();
WINDOWS_UNSUPPORTED_OPTIONS.add(STD_SOCK_OPT_SO_REUSEPORT);
}

private final ServerSocketChannel serverSocketChannel;

Expand Down Expand Up @@ -64,7 +73,13 @@ public boolean isSupported(Option option) {
}

private boolean isSupported(SocketOption socketOption) {
return socketOption != null && serverSocketChannel.supportedOptions().contains(socketOption);
if (socketOption == null) {
return false;
}
if (OS.isWindows() && WINDOWS_UNSUPPORTED_OPTIONS.contains(socketOption)) {
return false;
}
return serverSocketChannel.supportedOptions().contains(socketOption);
}

@Override
Expand Down