Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: integration tests in CI. #581

Merged
merged 1 commit into from Apr 11, 2024
Merged

Conversation

dblock
Copy link
Member

@dblock dblock commented Apr 11, 2024

 1) omniauth works
     Failure/Error: get '/'

     ArgumentError:
       invalid secret: 24, must be >=64
     # ./spec/integration/omniauth/integration_spec.rb:34:in `block (2 levels) in <top (required)>'
     # ./spec/integration/omniauth/integration_spec.rb:25:in `block (2 levels) in <top (required)>'

https://github.com/hashie/hashie/actions/runs/8597426729/job/23574774172

Rails secret min length has changed in a minor version?

@dangerpr-bot
Copy link

1 Warning
⚠️ Unless you're refactoring existing code or improving documentation, please update CHANGELOG.md.

Here's an example of a CHANGELOG.md entry:

* [#581](https://github.com/hashie/hashie/pull/581): Fix: integration tests in ci - [@dblock](https://github.com/dblock).

Generated by 🚫 Danger

@dblock dblock merged commit 8a842ef into hashie:master Apr 11, 2024
11 checks passed
@dblock dblock deleted the fix-integration branch April 11, 2024 14:18
@dblock dblock mentioned this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants