Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #580

Merged
merged 1 commit into from Apr 11, 2024
Merged

Fix typos #580

merged 1 commit into from Apr 11, 2024

Conversation

kianmeng
Copy link
Contributor

@kianmeng kianmeng commented Apr 8, 2024

Found via typos --format brief

Found via `typos --format brief`
@dblock
Copy link
Member

dblock commented Apr 8, 2024

The test failure is probably unrelated, but maybe you can look into it for a separate PR? We usually hold changes until CI goes green.

@kianmeng
Copy link
Contributor Author

kianmeng commented Apr 9, 2024

The test failure is probably unrelated, but maybe you can look into it for a separate PR? We usually hold changes until CI goes green.

Use `bundle info [gemname]` to see where a bundled gem is installed.

omniauth
  does not log anything to STDOUT when initializing
  works (FAILED - 1)

Failures:

  1) omniauth works
     Failure/Error: get '/'

     ArgumentError:
       invalid secret: 24, must be >=64
     # ./spec/integration/omniauth/integration_spec.rb:34:in `block (2 levels) in <top (required)>'
     # ./spec/integration/omniauth/integration_spec.rb:25:in `block (2 levels) in <top (required)>'

Finished in 0.0854 seconds (files took 0.08838 seconds to load)
2 examples, 1 failure

Failed examples:

rspec ./spec/integration/omniauth/integration_spec.rb:33 # omniauth works

Based on the error, most likely nothing to do with typos changes. I'm not familiar with Ruby, hence I doubt I can help much.

@dblock
Copy link
Member

dblock commented Apr 11, 2024

I fixed the integration test failures in #581.

@dblock dblock merged commit d07b2a3 into hashie:master Apr 11, 2024
10 of 11 checks passed
@kianmeng
Copy link
Contributor Author

🥳 🥳 🥳 🥳 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants