Test with Ruby 2.7 #524
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,38 +1,37 @@ | ||
| language: ruby | ||
| cache: bundler | ||
|
|
||
| rvm: | ||
| - 2.7 | ||
| - 2.6 | ||
| - 2.5 | ||
| - 2.4 | ||
| - 2.3 | ||
| - 2.2 | ||
| - 2.1 | ||
| - ruby-head | ||
| - jruby-9.2.11.1 | ||
| - jruby-head | ||
|
|
||
| matrix: | ||
| include: | ||
| - rvm: 2.5 | ||
|
There was a problem hiding this comment. Do you want these to always run with the latest ruby? In this case, 2.7? Same for the integration tests below. |
||
| name: "Run Danger and Code Climate" | ||
| before_script: | ||
| - bundle exec danger | ||
| after_script: | ||
| - bundle exec codeclimate-test-reporter | ||
| - rvm: 2.5 | ||
| name: "Integration Tests" | ||
| install: | ||
| - for dir in spec/integration/*; do BUNDLE_GEMFILE=$dir/Gemfile bundle; done | ||
| script: | ||
| - set -e ; for dir in spec/integration/*; do BUNDLE_GEMFILE=$dir/Gemfile bundle exec rspec $dir; done | ||
|
Comment on lines
-27
to
-28
There was a problem hiding this comment. I saw that this was tested on bionic, but is there a specific reason why 2.6 would need to be tested on bionic and the rest not? There was a problem hiding this comment. There was some reason, but I don't remember what it was 😅 |
||
| - rvm: rbx-3 | ||
| dist: trusty | ||
| bundler_args: --retry 0 | ||
| - rvm: jruby-9.0.5.0 | ||
| dist: trusty | ||
|
There was a problem hiding this comment. Not directly part of this PR, but do you wish to continue testing Rubinius? It seems that for testing Rubinius, the only option is to use an EOL Ubuntu. rubinius/rubinius#3819 There was a problem hiding this comment. Whoops, wrong line, should be on the But yeah, do you want to keep testing rbx-3? It seems to fail anyway. We could switch it for testing with TruffleRuby instead, WDYT? Also I'll try testing jruby 9.0 on xenial. There was a problem hiding this comment. Don't know what we want for Rubinius TBH. I was OK removing it a long time ago. |
||
| allow_failures: | ||
| - rvm: ruby-head | ||
| - rvm: jruby-head | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should pick the latest patch version, so it doesn't have to be micro-managed with every patch release.