Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with Ruby 2.7 #524

Merged
merged 7 commits into from May 29, 2020
Merged

Test with Ruby 2.7 #524

merged 7 commits into from May 29, 2020

Conversation

aried3r
Copy link
Contributor

@aried3r aried3r commented May 29, 2020

aried3r and others added 3 commits May 29, 2020 10:38
Also switch testing jruby-head from EOL Ubuntu to Travis default (xenial).
Comment on lines -27 to -28
- rvm: 2.6.6
dist: bionic
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that this was tested on bionic, but is there a specific reason why 2.6 would need to be tested on bionic and the rest not?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No specific reason.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was some reason, but I don't remember what it was 😅

Comment on lines +5 to +11
- 2.7
- 2.6
- 2.5
- 2.4
- 2.3
- 2.2
- 2.1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should pick the latest patch version, so it doesn't have to be micro-managed with every patch release.

.travis.yml Outdated
Comment on lines 15 to 18
- rvm: 2.5.3
- rvm: 2.5
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want these to always run with the latest ruby? In this case, 2.7? Same for the integration tests below.

.travis.yml Outdated
Comment on lines 33 to 34
- rvm: jruby-9.0.5.0
dist: trusty
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not directly part of this PR, but do you wish to continue testing Rubinius? It seems that for testing Rubinius, the only option is to use an EOL Ubuntu.

rubinius/rubinius#3819
https://docs.travis-ci.com/user/languages/ruby/#rubinius

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, wrong line, should be on the rbx-3 line, not jruby. My bad!

But yeah, do you want to keep testing rbx-3? It seems to fail anyway. We could switch it for testing with TruffleRuby instead, WDYT?

Also I'll try testing jruby 9.0 on xenial.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know what we want for Rubinius TBH. I was OK removing it a long time ago.

@aried3r
Copy link
Contributor Author

aried3r commented May 29, 2020

Ok, so this has grown much bigger than I intended.

I will gladly roll back any unwanted changes, but I thought it's better to have an actual PR as a proposal than merely discuss possibilities. :)

@aried3r aried3r marked this pull request as ready for review May 29, 2020 09:29
@aried3r
Copy link
Contributor Author

aried3r commented May 29, 2020

Of course Ruby 2.7 is now stuck that I want to test if fast_finish: true works as intended :D

Screenshot 2020-05-29 at 11 30 43

@dblock dblock merged commit 694f2e7 into hashie:master May 29, 2020
@dblock
Copy link
Member

dblock commented May 29, 2020

Thanks for cleaning this up and adding Ruby 2.7!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants