Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hashie mascot #522

Merged
merged 12 commits into from May 8, 2020
Merged

Hashie mascot #522

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9f9b967
add eierlegende Wollmilchsau mascot svg.
carolineartz May 4, 2020
517888e
Add mascot image to README.
carolineartz May 4, 2020
7619589
Link to mascot info.
carolineartz May 4, 2020
ab8561a
Add some padding to mascot image.
carolineartz May 4, 2020
58eb846
Add padding below image.
carolineartz May 4, 2020
99150b0
Adjust spacing of graphic within image.
carolineartz May 4, 2020
8a9023a
remove height from svg.
carolineartz May 4, 2020
2538e68
Final adjustment of spacing.
carolineartz May 4, 2020
025aac0
add locaation qualifier to link path for image src.
carolineartz May 4, 2020
62f76d4
Update changelog.
carolineartz May 4, 2020
09864b0
Rename file to mascot.svg.
carolineartz May 4, 2020
b781ad0
Add extension to asset references in README.
carolineartz May 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -36,6 +36,7 @@ scheme are considered to be bugs.

### Miscellaneous

* [#522](https://github.com/hashie/hashie/pull/522): Added eierlegende Wollmilchsau mascot graphic - [@carolineartz](https://github.com/carolineartz).
* Your contribution here.

## [4.1.0] - 2020-02-01
Expand Down
5 changes: 4 additions & 1 deletion README.md
View file
Open in desktop
Expand Up @@ -6,7 +6,7 @@
[![Test Coverage](https://api.codeclimate.com/v1/badges/7a0b42c8a22c945571fd/test_coverage)](https://codeclimate.com/github/hashie/hashie/test_coverage)
[![Maintainability](https://api.codeclimate.com/v1/badges/7a0b42c8a22c945571fd/maintainability)](https://codeclimate.com/github/hashie/hashie/maintainability)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh...its still not rendering...You know what is especially strange about this... if you look at my forked repo branch here

https://github.com/carolineartz/hashie/tree/hashie-mascot#mascot

image

I feel like I have come across this before in forks but I just can't remember what I did about it 🤦‍♀️

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me in https://github.com/hashie/hashie/blob/b781ad001de926710a287dc2b172d5b48b85ef30/README.md

Hashie is a growing collection of tools that extend Hashes and make them more useful.
[![eierlegende Wollmilchsau](./mascot)](#mascot) Hashie is a growing collection of tools that extend Hashes and make them more useful.
Copy link
Member

@dblock dblock May 5, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to render on Github? Needs .svg.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doh!


## Installation

Expand Down Expand Up @@ -1028,6 +1028,9 @@ mapper["Get off my lawn!"] # => "Forget your lawn, old man!"

If this value is too low or too high for your needs, you can tune it by setting: `rash.optimize_every = n`.

## Mascot
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just include the mascot on top?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scratch that, I see it.

[![eierlegende Wollmilchsau](./mascot)](https://en.wiktionary.org/wiki/eierlegende_Wollmilchsau) Meet Hashie's "offical" mascot, the [eierlegende Wollmilchsau](https://en.wiktionary.org/wiki/eierlegende_Wollmilchsau)!

## Contributing

See [CONTRIBUTING.md](CONTRIBUTING.md)
Expand Down