Hashie mascot #522
Merged
Hashie mascot #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
reviewed
May 5, 2020
README.md
Outdated
| @@ -6,7 +6,7 @@ | |||
| [](https://codeclimate.com/github/hashie/hashie/test_coverage) | |||
| [](https://codeclimate.com/github/hashie/hashie/maintainability) | |||
|
|
|||
| Hashie is a growing collection of tools that extend Hashes and make them more useful. | |||
| [](#mascot) Hashie is a growing collection of tools that extend Hashes and make them more useful. | |||
There was a problem hiding this comment.
Doesn't seem to render on Github? Needs .svg.
carolineartz
commented
May 8, 2020
| @@ -6,7 +6,7 @@ | |||
| [](https://codeclimate.com/github/hashie/hashie/test_coverage) | |||
| [](https://codeclimate.com/github/hashie/hashie/maintainability) | |||
|
|
|||
There was a problem hiding this comment.
Huh...its still not rendering...You know what is especially strange about this... if you look at my forked repo branch here
https://github.com/carolineartz/hashie/tree/hashie-mascot#mascot
I feel like I have come across this before in forks but I just can't remember what I did about it 🤦♀️
There was a problem hiding this comment.
dblock
reviewed
May 8, 2020
| @@ -1028,6 +1028,9 @@ mapper["Get off my lawn!"] # => "Forget your lawn, old man!" | |||
|
|
|||
| If this value is too low or too high for your needs, you can tune it by setting: `rash.optimize_every = n`. | |||
|
|
|||
| ## Mascot | |||
There was a problem hiding this comment.
Can we just include the mascot on top?
|
I merged it. Hope it doesn't break the build. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the eierlegende Wollmilchsau as the "official" mascot for Hashie, as suggested in #460. The graphic I created is displayed by the title of the gem as well in a small mascot section linked from the image towards the end of the docs. The mascot section links to the wikipedia page on the "animal"...