Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dynamodb HA lock race #6512

Merged
merged 2 commits into from Apr 2, 2019
Merged

Fix dynamodb HA lock race #6512

merged 2 commits into from Apr 2, 2019

Conversation

mahmoudm
Copy link
Contributor

@mahmoudm mahmoudm commented Apr 1, 2019 •
edited

Fixes #5828

@hashicorp-cla
Copy link

hashicorp-cla commented Apr 1, 2019 •
edited

CLA assistant check
All committers have signed the CLA.

@mahmoudm mahmoudm mentioned this pull request Apr 1, 2019
Closed
@kalafut
Copy link
Contributor

kalafut commented Apr 1, 2019 •
edited

@mahmoudm The reason the CLA check is failing is because the commit was made with your Palantir email address, which presumably isn't part of your GitHub account. Can you add that, or alternatively rewrite the commit with the email you're using on GH and is already CLA signed?

@mahmoudm
Copy link
Contributor Author

mahmoudm commented Apr 1, 2019

yup - I just realized that. fixed the email to be my personal one.

@kalafut
Copy link
Contributor

kalafut commented Apr 1, 2019

Thanks!

@kalafut kalafut self-assigned this Apr 1, 2019
@kalafut kalafut requested a review from calvn April 2, 2019 22:32
@briankassouf briankassouf merged commit 98079d8 into hashicorp:master Apr 2, 2019
@briankassouf briankassouf added this to the 1.1.1 milestone Apr 2, 2019
@michelvocks michelvocks mentioned this pull request Dec 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvn calvn calvn approved these changes

Assignees

@kalafut kalafut

Labels
None yet
Projects
None yet
Milestone
1.1.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mahmoudm @hashicorp-cla @kalafut @calvn @briankassouf