Fix dynamodb HA lock race

[mahmoudm]

Fixes #5828

[mahmoudm]

I'm still testing this change, opened to start the discussion. I'll ping back when tested fully.

[mahmoudm]

I've tested this and deployed it to production and it works as expected.

[kalafut]

@mahmoudm Thanks for digging in to this. I've reviewed it briefly and it looks reasonable. Can you please add a test to dynambo_test.go (i.e. another special purpose test like testDynamoDBLockTTL) that causes the sequence which should fail without your changes? To run those tests you'll need Docker installed, and to just run the Dynamo ones you can use go test ./physical/dynamodb

[hashicorp-cla]

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

---

Mahmoud Abdelsalam seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

_{Have you signed the CLA already but the status is still pending? Recheck it.}

[maartenvanderhoef]

Hi @mahmoudm would you be able to find time to finish the PR ?

[kalafut]

@mahmoudm Thanks for working to help clear the CLA block. It looks like some older commits are under another GitHub ID that's no longer active. Would you mind taking your current code and pushing a new PR, squashed without reference to the old ID? We can then close out this PR and I'll help integrate the new one.

[mahmoudm]

should be good now - LMK if this doesn't work

[kalafut]

@mahmoudm Despite the force-push and the history only showing the one commit, the CLA checker is still referencing the old email. Could you push the work (i.e the same squashed commit, possibly as a new branch in your repo) as a new PR? I think that may be simplest way to appease the CLA checker. Thanks for your patience with this!

[mahmoudm]

ok, opened here: #6512