Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: dashboard overview heading levels #26873

Merged
merged 1 commit into from
May 8, 2024
Merged

bugfix: dashboard overview heading levels #26873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions ui/app/components/dashboard/client-count-card.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@

<Hds::Card::Container @hasBorder={{true}} class="has-padding-l" data-test-card="client-count">
<div class="is-flex-between">
<h3 class="title is-4 has-bottom-margin-xxs" data-test-client-count-title>
<h2 class="title is-4 has-bottom-margin-xxs" data-test-client-count-title>
Client count
</h3>
</h2>

<LinkTo @route="vault.cluster.clients">Details</LinkTo>
</div>
Expand Down
2 changes: 1 addition & 1 deletion ui/app/components/dashboard/learn-more-card.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
~}}

<Hds::Card::Container @hasBorder={{true}} class="has-padding-l" data-test-card="learn-more">
<h3 class="title is-4 has-bottom-margin-xxs" data-test-learn-more-title>Learn more</h3>
<h2 class="title is-4 has-bottom-margin-xxs" data-test-learn-more-title>Learn more</h2>
<div class="sub-text" data-test-learn-more-subtext>
Explore the features of Vault and learn advance practices with the following tutorials and documentation.
</div>
Expand Down
8 changes: 4 additions & 4 deletions ui/app/components/dashboard/quick-actions-card.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@
~}}

<Hds::Card::Container @hasBorder={{true}} class="has-padding-l" data-test-card="quick-actions">
<h3 class="title is-4">Quick actions</h3>
<h2 class="title is-4">Quick actions</h2>
{{#if this.filteredSecretEngines}}
<div class="has-top-margin-m has-bottom-margin-m">
<h4 class="title is-marginless is-6" data-test-card-subtitle="secrets-engines">Secrets engines</h4>
<h3 class="title is-marginless is-6" data-test-card-subtitle="secrets-engines">Secrets engines</h3>
<p class="is-size-8 has-top-margin-xxs has-bottom-margin-s has-text-grey">Supported engines include databases, KV
version 2, and PKI.</p>
<SearchSelect
Expand All @@ -28,7 +28,7 @@
</div>

{{#if this.selectedEngine}}
<h4 id="action-select-title" class="title is-6" data-test-card-subtitle="secrets-engines">Action</h4>
<h3 id="action-select-title" class="title is-6" data-test-card-subtitle="secrets-engines">Action</h3>
<Select
@name="action-select"
@options={{this.actionOptions}}
Expand All @@ -49,7 +49,7 @@
@onChange={{fn (mut this.paramValue)}}
/>
{{else}}
<h4 class="title is-6" data-test-card-subtitle="param">{{this.searchSelectParams.title}}</h4>
<h3 class="title is-6" data-test-card-subtitle="param">{{this.searchSelectParams.title}}</h3>

<SearchSelect
class="is-flex-grow-1"
Expand Down
2 changes: 1 addition & 1 deletion ui/app/components/dashboard/secrets-engines-card.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
data-test-card="secrets-engines"
>
<div class="is-flex-between">
<h3 class="title is-4 has-left-margin-xxs" data-test-dashboard-card-header="Secrets engines">Secrets engines</h3>
<h2 class="title is-4 has-left-margin-xxs" data-test-dashboard-card-header="Secrets engines">Secrets engines</h2>

{{#if this.filteredSecretsEngines}}
<LinkTo class="has-right-margin-xxs" @route="vault.cluster.secrets.backends">
Expand Down