Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: dashboard overview heading levels #26873

Merged
merged 1 commit into from May 8, 2024

Conversation

MelSumner
Copy link
Contributor

@MelSumner MelSumner commented May 7, 2024

If merged, this PR resolves the issue where dashboard heading levels did not only increase by one. There should be no visual change with this PR, only underlying markup change.

Bug:
CleanShot 2024-05-07 at 17 00 02@2x

How it looked before:
CleanShot 2024-05-07 at 17 01 45@2x

How it looks after:
CleanShot 2024-05-07 at 17 03 33@2x

@MelSumner MelSumner added the a11y label May 7, 2024
@MelSumner MelSumner requested a review from a team as a code owner May 7, 2024 22:03
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 7, 2024
Copy link

github-actions bot commented May 7, 2024

Build Results:
All builds succeeded! ✅

Copy link

github-actions bot commented May 7, 2024

CI Results:
All Go tests succeeded! ✅

@KristinLBradley KristinLBradley requested review from KristinLBradley and removed request for KristinLBradley May 7, 2024 22:54
Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hellobontempo hellobontempo added this to the 1.17.0-rc milestone May 8, 2024
@hellobontempo hellobontempo merged commit 459e62a into main May 8, 2024
34 of 39 checks passed
@hellobontempo hellobontempo deleted the melsumner/bug-heading-levels branch May 8, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants