Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: patch lodash.template nested dependency #26626

Merged
merged 1 commit into from Apr 29, 2024
Merged

UI: patch lodash.template nested dependency #26626

merged 1 commit into from Apr 29, 2024

Conversation

hashishaw
Copy link
Collaborator

@hashishaw hashishaw commented Apr 24, 2024 •
edited

ember-cli and ember-fetch both use lodash.template which is outdated. This PR patches the version we import with the changes from this change to lodash

@hashishaw hashishaw added ui pr/no-changelog backport/1.14.x Backport changes to `release/1.14.x` backport/1.15.x Backport changes to `release/1.15.x` backport/1.16.x Backport changes to `release/1.16.x` labels Apr 24, 2024
@hashishaw hashishaw added this to the 1.14.13 milestone Apr 24, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Apr 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 24, 2024 •
edited

CI Results:
All Go tests succeeded! ✅

@hashishaw hashishaw marked this pull request as ready for review April 25, 2024 14:47
@hashishaw hashishaw requested a review from a team as a code owner April 25, 2024 14:47
@github-actions GitHub Actions
Copy link

Build Results:
All builds succeeded! ✅

Monkeychip
Monkeychip approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool to see the use of yarn patch. Non-blocking, but it might be a good idea to run enterprise tests locally.

@hashishaw hashishaw merged commit 670ec76 into main Apr 29, 2024
66 of 68 checks passed
@hashishaw hashishaw deleted the ui/VAULT-26222/patch-lodash.template branch April 29, 2024 16:49
This was referenced Apr 29, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Monkeychip Monkeychip Monkeychip approved these changes

Assignees
No one assigned
Labels
backport/1.14.x Backport changes to `release/1.14.x` backport/1.15.x Backport changes to `release/1.15.x` backport/1.16.x Backport changes to `release/1.16.x` hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui
Projects
None yet
Milestone
1.14.13
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hashishaw @Monkeychip