Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of UI: patch lodash.template nested dependency into release/1.14.x #26684

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Backport of UI: patch lodash.template nested dependency into release/1.14.x #26684

merged 1 commit into from
Apr 29, 2024

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #26626 to be assessed for backporting due to the inclusion of the label backport/1.14.x.

The below text is copied from the body of the original PR.

ember-cli and ember-fetch both use lodash.template which is outdated. This PR patches the version we import with the changes from this change to lodash

Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/ui/VAULT-26222/patch-lodash.template/frequently-fast-finch branch from 2baa7de to 3ed352e Compare April 29, 2024 16:50
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Apr 29, 2024
@github-actions GitHub Actions
Copy link

Build Results:
All builds succeeded! ✅

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 29, 2024 •
edited

CI Results:
All Go tests succeeded! ✅

hashishaw
hashishaw approved these changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out locally, ent tests pass

@hashishaw hashishaw added this to the 1.14.13 milestone Apr 29, 2024
@hashishaw hashishaw added the ui label Apr 29, 2024
@hashishaw hashishaw enabled auto-merge (squash) April 29, 2024 18:19
@hashishaw hashishaw disabled auto-merge April 29, 2024 19:03
@hashishaw hashishaw enabled auto-merge (squash) April 29, 2024 19:28
@hashishaw hashishaw merged commit 3c6dc7d into release/1.14.x Apr 29, 2024
25 of 26 checks passed
@hashishaw hashishaw deleted the backport/ui/VAULT-26222/patch-lodash.template/frequently-fast-finch branch April 29, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashishaw hashishaw hashishaw approved these changes

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Milestone
1.14.13
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hc-github-team-secure-vault-core @hashishaw