UI/OIDC auth bug for cloud ui HCP namespace flag #16886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashishaw
reviewed
Aug 25, 2022
hellobontempo
commented
Aug 25, 2022
hashishaw
reviewed
Aug 26, 2022
hashishaw
reviewed
Aug 26, 2022
hashishaw
reviewed
Aug 26, 2022
|
Hey folks, if this PR doesn't merge today, could someone please re-milestone it for 1.10.7, as it will miss the freeze? |
hashishaw
reviewed
Aug 26, 2022
| assert.propContains( | ||
| this.windowStub.lastCall.args[0], | ||
| { | ||
| code: undefined, |
There was a problem hiding this comment.
I think leaving these as undefined might lead to some weird behavior on the postMessage receiver side, could we default to empty string if these don't exist? A bit more verbose but something like:
let queryParams = { source, path: path || '', code: code || '', state: state || '' };
Maybe as a follow-on, because I think that's not likely a scenario we'll get into in real life
hashishaw
reviewed
Aug 26, 2022
| // only replace namespace param from cluster if state has a namespace | ||
| if (state?.includes(',ns=')) { | ||
| [state, namespace] = state.split(',ns='); | ||
| } | ||
| path = window.decodeURIComponent(path); | ||
| const source = 'oidc-callback'; // required by event listener in auth-jwt component | ||
| let queryParams = { source, namespace, path, code, state }; |
There was a problem hiding this comment.
One more cleanup task (follow-on) is, if namespace doesn't exist don't include it. So remove from queryParams here and then below do
if (namespace) queryParams.namespace = namespace
This was referenced Aug 26, 2022
hellobontempo
deleted the
ui/VAULT-7938/oidc-auth-bug-for-hcp-namespace-flag
branch
hellobontempo
changed the title
This was referenced Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
afterModel()hook so that it can handle both when a namespace comes in as a param from the cluster:namespaceQueryParam = 'admin'and when it's attached to the state from the route params:state="st_z6y8L12PndJ33FmW1Ls2,ns=admin"The namespace passed via state will take precedence