Backport of UI/OIDC auth bug for hcp namespace flag into release/1.11.x #16908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
requested a review
from austingebauer
as a code owner
hc-github-team-secure-vault-core
force-pushed
the
backport/ui/VAULT-7938/oidc-auth-bug-for-hcp-namespace-flag/severely-cunning-cicada
branch
from
c90f01e
to
6faf92a
Compare
hashishaw
approved these changes
Aug 26, 2022
hellobontempo
deleted the
backport/ui/VAULT-7938/oidc-auth-bug-for-hcp-namespace-flag/severely-cunning-cicada
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #16886 to be assessed for backporting due to the inclusion of the label backport/1.11.x.
The below text is copied from the body of the original PR.
Fixes the
afterModel()hook so that it can handle both when a namespace comes in as a param from the cluster:namespaceQueryParam = 'admin'and when it's attached to the state from the route params:state="st_z6y8L12PndJ33FmW1Ls2,ns=admin"The namespace passed via state will take precedence
Overview of commits