UI: Fix metadata tab not showing given policy #15824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellobontempo
requested changes
Jun 6, 2022
| @@ -29,6 +29,18 @@ let writeSecret = async function (backend, path, key, val) { | |||
| return editPage.createSecret(path, key, val); | |||
| }; | |||
|
|
|||
| let deleteEngine = async function (enginePath, assert) { | |||
Co-authored-by: claire bontempo <68122737+hellobontempo@users.noreply.github.com>
hellobontempo
approved these changes
Jun 7, 2022
This was referenced Jun 7, 2022
hashishaw
added a commit
that referenced
this pull request
Jun 8, 2022
* Update path that metadata tab checks capabilities against * Add changelog * Update test to handle this case * Fix tests url Co-authored-by: claire bontempo <68122737+hellobontempo@users.noreply.github.com>
hashishaw
added a commit
that referenced
this pull request
Jun 8, 2022
* Update path that metadata tab checks capabilities against * Add changelog * Update test to handle this case * Fix tests url Co-authored-by: claire bontempo <68122737+hellobontempo@users.noreply.github.com>
hashishaw
added a commit
that referenced
this pull request
Jun 28, 2022
hashishaw
added a commit
that referenced
this pull request
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the path what capabilities are checked against when evaluating whether to show the metadata tab on KV v2 secrets engine. Since metadata is only ever connected to a secret with an ID, we need to provide the ID on that capability path so that it is checked for each specific secret view.
Repro steps for the bug are excellently outlined in issue #15347