Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of UI: Fix metadata tab not showing given policy into release/1.10.x #15848

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #15824 to be assessed for backporting due to the inclusion of the label backport/1.10.x.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


This PR fixes the path what capabilities are checked against when evaluating whether to show the metadata tab on KV v2 secrets engine. Since metadata is only ever connected to a secret with an ID, we need to provide the ID on that capability path so that it is checked for each specific secret view.

Repro steps for the bug are excellently outlined in issue #15347


Overview of commits

@hashicorp-cla
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@hashishaw hashishaw added this to the 1.10.4 milestone Jun 7, 2022
@hashishaw hashishaw added ui backport bug Used to indicate a potential bug labels Jun 7, 2022
@hashishaw
Copy link
Collaborator

No commit, doing this manually

@hashishaw hashishaw closed this Jun 7, 2022
@hashishaw hashishaw deleted the backport/ui/VAULT-6165/fix-metadata-tab-permissions/evenly-tidy-llama branch June 7, 2022 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport bug Used to indicate a potential bug ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants