Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates leasId to leaseId #15685

Merged
merged 2 commits into from Jun 13, 2022
Merged

updates leasId to leaseId #15685

merged 2 commits into from Jun 13, 2022

Conversation

ksatirli
Copy link
Member

Hello maintainers! 馃憢馃徏

While working on some demos with the AWS backend, I noticed that in the Generate AWS Credentials screen, when clicking on the blue Copy credentials button, the following payload is copied:

{
"accessKey": "AKIAIOSFODNN7EXAMPLE",
"secretKey": "wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY",
"leasId": "aws/creds/consumer/L0mkTBzIsjki3jojjgrcICVo.at2AD"
}

I believe that leasId ought to be leaseId, in line with this.leaseId.

@hsimon-hashicorp hsimon-hashicorp added ui bug Used to indicate a potential bug labels May 31, 2022
@hashishaw
Copy link
Collaborator

Hi there @ksatirli, thanks for catching this! I'm going to check how far back we need to port this change, but in the meantime would you please add a changelog? Instructions can be found here.

@hashishaw hashishaw added this to the 1.9.7 milestone Jun 6, 2022
@ksatirli
Copy link
Member Author

ksatirli commented Jun 8, 2022

@hashishaw done!

Copy link
Collaborator

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃殌 Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants