Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of updates leasId to leaseId into release/1.9.x #15959

Merged

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #15685 to be assessed for backporting due to the inclusion of the label backport/1.9.x.

The below text is copied from the body of the original PR.


Hello maintainers! 👋🏼

While working on some demos with the AWS backend, I noticed that in the Generate AWS Credentials screen, when clicking on the blue Copy credentials button, the following payload is copied:

{
"accessKey": "AKIAIOSFODNN7EXAMPLE",
"secretKey": "wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY",
"leasId": "aws/creds/consumer/L0mkTBzIsjki3jojjgrcICVo.at2AD"
}

I believe that leasId ought to be leaseId, in line with this.leaseId.


Overview of commits

@hashishaw hashishaw enabled auto-merge (squash) June 14, 2022 19:36
@hashishaw hashishaw added this to the 1.9.7 milestone Jun 14, 2022
@hashishaw hashishaw merged commit 42a4f57 into release/1.9.x Jun 14, 2022
@hashishaw hashishaw deleted the backport/ksatirli-patch-1/scarcely-discrete-boxer branch June 15, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants