Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

secrets/ad: change improvement to feature in changelog #12095

Merged
merged 2 commits into from Jul 15, 2021
Merged

secrets/ad: change improvement to feature in changelog #12095

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6585382
secrets/ad: change improvement to feature in changelog
jasonodonnell Jul 15, 2021
b677cc2
Update per feature requirements
jasonodonnell Jul 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions changelog/11942.txt
View file
Open in desktop
@@ -1,3 +1,3 @@
```release-note:improvement
plugins/ad: Added rotate-role endpoint for manual service account password rotations
```release-note:feature
secrets/ad: Add rotate-role endpoint for manual service account password rotations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am unsure, but this doesn't look quite right. Unless I am reading the changelog formatting wiki too literally. (which I might be doing)

But I think this should be

Suggested change
secrets/ad: Add rotate-role endpoint for manual service account password rotations
**Active Directory service account manual rotation**: Add rotate-role endpoint for manual service account password rotations

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep that's right! If we're changing it to be a feature, it should be in the format that @fairclothjm is suggesting.

```