secrets/ad: change improvement to feature in changelog #12095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonodonnell
requested review from
calvn,
fairclothjm,
austingebauer,
MilenaHC and
vinay-gopalan
austingebauer
approved these changes
Jul 15, 2021
fairclothjm
reviewed
Jul 15, 2021
changelog/11942.txt
Outdated
| ```release-note:improvement | ||
| plugins/ad: Added rotate-role endpoint for manual service account password rotations | ||
| ```release-note:feature | ||
| secrets/ad: Add rotate-role endpoint for manual service account password rotations |
There was a problem hiding this comment.
I am unsure, but this doesn't look quite right. Unless I am reading the changelog formatting wiki too literally. (which I might be doing)
But I think this should be
Suggested change
| secrets/ad: Add rotate-role endpoint for manual service account password rotations | |
| **Active Directory service account manual rotation**: Add rotate-role endpoint for manual service account password rotations |
There was a problem hiding this comment.
Yep that's right! If we're changing it to be a feature, it should be in the format that @fairclothjm is suggesting.
fairclothjm
approved these changes
Jul 15, 2021
jasonodonnell
added a commit
that referenced
this pull request
Jul 15, 2021
* secrets/ad: change improvement to feature in changelog * Update per feature requirements
jasonodonnell
added a commit
that referenced
this pull request
Jul 15, 2021
jartek
pushed a commit
to jartek/vault
that referenced
this pull request
Sep 11, 2021
* secrets/ad: change improvement to feature in changelog * Update per feature requirements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the CHANGELOG file for #11942 to follow standards for changelog entries.