Refactor SchemaMerger interface
#335
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
dbanck
force-pushed
the
c-refactoring-prep
branch
2 times, most recently
from
022d7ad
to
5aad29f
Compare
ansgarm
reviewed
Apr 11, 2024
| } | ||
|
|
||
| type ModuleReader interface { | ||
| ModuleCalls(modPath string) (tfmod.ModuleCalls, error) | ||
| type StateReader interface { |
There was a problem hiding this comment.
I'm sure I just forgot, but maybe a comment might help here to what a "state" is to terraform-schema and what the state reader handles?
dbanck
force-pushed
the
c-refactoring-prep
branch
from
5aad29f
to
9254447
Compare
dbanck
force-pushed
the
c-refactoring-prep
branch
from
a56f5f7
to
34035ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the language server state splitting (hashicorp/terraform-ls#1626), we now have to get the declared module calls and the installed module calls from different sources.
We now have a separate method for each of them instead of a combined one.