Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LS state & performance refactoring #1667

Draft
wants to merge 92 commits into
base: main
Choose a base branch
from
Draft

LS state & performance refactoring #1667

wants to merge 92 commits into from
+10,795 −8,423

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Mar 22, 2024 •
edited

WIP

TODO

  • Fix tests
  • Update DidChangeWatchedFiles handler
  • Update DidChangeWorkspaceFolders handler
  • Rework change notifications
    • globally
    • for module flavor
    • for variable flavor
    • for roots flavor
  • Check commands
  • Rework module completion hooks
  • Update providerRequirementsForModule manifest check
  • Run validation related jobs

Closes:

@dbanck dbanck self-assigned this Mar 22, 2024
@dbanck dbanck force-pushed the c-refactoring-prep branch 6 times, most recently from b0ad1b4 to c8d820d Compare April 17, 2024 11:10
@dbanck dbanck force-pushed the c-refactoring-prep branch 5 times, most recently from 914ac8b to 0c5e3d6 Compare April 25, 2024 08:03
dbanck added 19 commits May 24, 2024 11:39
@dbanck
Fix module feature tests
13c9732
@dbanck
Fix variable feature tests
724767e
@dbanck
Commit provider version transaction
4baa950
@dbanck
Improve root module discovery
799beb3
@dbanck
Wait for jobs before getting a decoder
e6d9797
@dbanck
Reduce log noise (Closes #1663)
3ed058a
@dbanck
Introduce doneChannel for waiting on message bus events
837e66c
@dbanck
Improve / fix handler tests
9a5db36
@dbanck
Check for module existance before waiting on metadata
954984b
@dbanck
Use done channel for didOpen events
f817108 
This will block until all jobs are scheduled
@dbanck
Increase job queue parallism
9cddf8b
@dbanck
Bugfix: Report ObtainSchema loading state
ca3d086
@dbanck
Fix DidChangeWatchedFiles test
9513374
@dbanck
Remove some walker tests
e8ff4e7 
I will recreate a similar test case in handlers/ because all
the required helpers live there
@dbanck
Wait until we decoded the submodules
32c2999
@dbanck
Add done channels for didChange
3c4e7dd
@dbanck
Skip reverse reference tests
e78aacf
@dbanck
Depend on module calls for target collection
8c4197e
@dbanck
Fix root module discovery
cb0cb38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansgarm ansgarm ansgarm left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@dbanck dbanck

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dbanck @ansgarm @jpogran