Migrate from SDKv2 => Framework #142
Conversation
bendbennett
changed the title
| "github.com/hashicorp/terraform-plugin-framework/tfsdk" | ||
| "github.com/hashicorp/terraform-plugin-framework/types" | ||
| ) | ||
|
|
There was a problem hiding this comment.
One thing that I picked up is to make sure I declare top of the file what interfaces each type is expected to implement.
For example, in the TLS FW PR I have this pretty much everywhere:
type (
privateKeyResourceType struct{}
privateKeyResource struct{}
)
var (
_ tfsdk.ResourceType = (*privateKeyResourceType)(nil)
_ tfsdk.Resource = (*privateKeyResource)(nil)
)This ensures that a) all the interfaces are enforced at compile time b) notice that I'm forcing receivers to be pointers, to avoid any surprise down the line where a call to a mutating method, doesn't apply the change to the struct in the expected way.
There was a problem hiding this comment.
Good shout. Have added in the relevant interface implementations.
internal/provider/provider.go
Outdated
| func New() *schema.Provider { | ||
| return &schema.Provider{ | ||
| Schema: map[string]*schema.Schema{}, | ||
| type provider struct { |
There was a problem hiding this comment.
Same as above here, about enforcing interfaces at compile time.
internal/provider/provider_test.go
Outdated
| "http": func() (tfprotov6.ProviderServer, error) { | ||
| return providerserver.NewProtocol6(New())(), nil | ||
| }, |
There was a problem hiding this comment.
Drive-by question: Can this use providerserver.NewProtocol6WithError(New()) instead?
There was a problem hiding this comment.
Sure thing! Done.
This PR contains breaking changes for:
Closes Allow accepting additional StatusCodes with custom fallback response #114
Closes: #140
Closes: #114
Closes: #107
Closes: #93
Closes: #41