Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove status code check and body attribute #140

Closed
wants to merge 5 commits into from

Conversation

bendbennett
Copy link
Contributor

@bendbennett bendbennett commented Jun 7, 2022

DO NOT MERGE: The changes in this PR have been incorporated into #142

This PR contains breaking changes for:

Closes #114

TODO: terraform-plugin-docs needs to be updated once tag which includes changes in hashicorp/terraform-plugin-docs#147 has been released.

@bendbennett bendbennett changed the title v3.0.0 Remove status code check and body attribute Jun 7, 2022
@bendbennett bendbennett added this to the v3.0.0 milestone Jun 13, 2022
@bendbennett bendbennett marked this pull request as ready for review June 13, 2022 08:57
@bendbennett bendbennett requested a review from a team as a code owner June 13, 2022 08:57
go.mod Outdated
@@ -3,7 +3,7 @@ module github.com/terraform-providers/terraform-provider-http
go 1.17

require (
github.com/hashicorp/terraform-plugin-docs v0.9.0
github.com/hashicorp/terraform-plugin-docs v0.9.1-0.20220606170027-27bf5535f4c6
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Requires release of tag containing hashicorp/terraform-plugin-docs#147

@pascal-hofmann
Copy link

The state migration for this seems to be missing. I get a lot of error messages with:

…could not be decoded from the state: unsupported attribute "body".

See https://www.terraform.io/plugin/sdkv2/resources/state-migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants