Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node not part of the cluster is not allowed to vote #477
node not part of the cluster is not allowed to vote #477
Changes from all commits
8d01054
9ed9594
3a2e405
8da6d8d
b4e2273
47da40c
10c6f7c
4aa895c
f22dae0
822cde2
e7a1af3
512d338
9e1e9c2
9e751db
8074fe5
2768524
6ea0aa4
ecd60c2
bfc9e23
b3507f1
aea65ca
4620c71
86d22fa
3621401
8631c97
634a602
a8af0db
d4932d0
86c4d96
eff27ce
4fa2eb0
0e724f0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need to do this? Any reason not to continue to use
req.Leader
? Why do we prefer the newRPCHeader.Addr
?If we are trying to phase it out, we should document that on the
Leader
field.Same question about the other two places we look at
Leader
orCandidate
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should aim to phaseout Leader and Candidate parameters, it make more sense to infer those values from the RPCHeader now and removing those will reduce the on the wire packet size sensibly. Also if we keep them it mean we need to document/test special cases behaviour (different values, Addr empty and Candidate not...).
I will add the deprecation comment for both Candidate and Leader