Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node not part of the cluster is not allowed to vote #477

Merged
merged 32 commits into from Mar 7, 2022
Merged

node not part of the cluster is not allowed to vote #477

merged 32 commits into from Mar 7, 2022

Commits on Oct 28, 2021

  1. add test to verify that a removed node is not able to vote

    @dhiaayachi
    dhiaayachi committed Oct 28, 2021
    Copy the full SHA
    8d01054 View commit details
    Browse the repository at this point in the history

  2. add some comments to the tests

    @dhiaayachi
    dhiaayachi committed Oct 28, 2021
    Copy the full SHA
    9ed9594 View commit details
    Browse the repository at this point in the history

  3. add wait loop to test

    @dhiaayachi
    dhiaayachi committed Oct 28, 2021
    Copy the full SHA
    3a2e405 View commit details
    Browse the repository at this point in the history

  4. remove test related to removed node voting

    @dhiaayachi
    dhiaayachi committed Oct 28, 2021
    Copy the full SHA
    8da6d8d View commit details
    Browse the repository at this point in the history

  5. add test that check a removed node is not allowed to vote

    @dhiaayachi
    dhiaayachi committed Oct 28, 2021
    Copy the full SHA
    b4e2273 View commit details
    Browse the repository at this point in the history

  6. add wait loop to make test more robust

    @dhiaayachi
    dhiaayachi committed Oct 28, 2021
    Copy the full SHA
    47da40c View commit details
    Browse the repository at this point in the history

  7. increase timeout

    @dhiaayachi
    dhiaayachi committed Oct 28, 2021
    Copy the full SHA
    10c6f7c View commit details
    Browse the repository at this point in the history

  8. Revert "increase timeout" 

    This reverts commit 316c59a.
    @dhiaayachi
    dhiaayachi committed Oct 28, 2021
    Copy the full SHA
    4aa895c View commit details
    Browse the repository at this point in the history

  9. add ID to RequestVoteRequest and check if the node is part of the c… 

    …luster before granting a vote
    @dhiaayachi
    dhiaayachi committed Oct 28, 2021
    Copy the full SHA
    f22dae0 View commit details
    Browse the repository at this point in the history

  10. use request protocol version to ensure we have the right version

    @dhiaayachi
    dhiaayachi committed Oct 28, 2021
    Copy the full SHA
    822cde2 View commit details
    Browse the repository at this point in the history

  11. add ID and Addr as part of RPCHeader and do not fill `Candidate… 

    …` and `Leader` in version > 3
    @dhiaayachi
    dhiaayachi committed Oct 28, 2021
    Copy the full SHA
    e7a1af3 View commit details
    Browse the repository at this point in the history

  12. return LeaderID as part of the Leader() api

    @dhiaayachi
    dhiaayachi committed Oct 28, 2021
    Copy the full SHA
    512d338 View commit details
    Browse the repository at this point in the history

  13. fix docstring

    @dhiaayachi
    dhiaayachi committed Oct 28, 2021
    Copy the full SHA
    9e1e9c2 View commit details
    Browse the repository at this point in the history

  14. fix retro compatibility with version 3

    @dhiaayachi
    dhiaayachi committed Oct 28, 2021
    Copy the full SHA
    9e751db View commit details
    Browse the repository at this point in the history

  15. fix string casting

    @dhiaayachi
    dhiaayachi committed Oct 28, 2021
    Copy the full SHA
    8074fe5 View commit details
    Browse the repository at this point in the history

  16. remove EncodeID and DecodeID from transport interface

    @dhiaayachi
    dhiaayachi committed Oct 28, 2021
    Copy the full SHA
    2768524 View commit details
    Browse the repository at this point in the history

  17. add missing leaderID initialization

    @dhiaayachi
    dhiaayachi committed Oct 28, 2021
    Copy the full SHA
    6ea0aa4 View commit details
    Browse the repository at this point in the history

  18. add protocol version 3 to version 4 upgrade test

    @dhiaayachi
    dhiaayachi committed Oct 28, 2021
    Copy the full SHA
    ecd60c2 View commit details
    Browse the repository at this point in the history

  19. increase test timeout

    @dhiaayachi
    dhiaayachi committed Oct 28, 2021
    Copy the full SHA
    bfc9e23 View commit details
    Browse the repository at this point in the history

  20. split test, and clean code

    @dhiaayachi
    dhiaayachi committed Oct 28, 2021
    Copy the full SHA
    b3507f1 View commit details
    Browse the repository at this point in the history

  21. add docstrings to RPCHeader

    @dhiaayachi
    dhiaayachi committed Oct 28, 2021
    Copy the full SHA
    aea65ca View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Matt Keeler <mkeeler@users.noreply.github.com>
    @dhiaayachi @mkeeler
    dhiaayachi and mkeeler committed Nov 24, 2021
    Copy the full SHA
    4620c71 View commit details
    Browse the repository at this point in the history

  2. Fix comment 

    Co-authored-by: Matt Keeler <mkeeler@users.noreply.github.com>
    @dhiaayachi @mkeeler
    dhiaayachi and mkeeler committed Nov 24, 2021
    Copy the full SHA
    86d22fa View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2021

  1. fix review comments

    @dhiaayachi
    dhiaayachi committed Nov 26, 2021
    Copy the full SHA
    3621401 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2021

  1. do not increment protocolVersion to 4 and rely on Addr/ID field being… 

    … nil to fallback on the old fields.
    @dhiaayachi
    dhiaayachi committed Nov 29, 2021
    Copy the full SHA
    8631c97 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2021

  1. deprecate Leader in favor of LeaderWithID

    @dhiaayachi
    dhiaayachi committed Nov 30, 2021
    Copy the full SHA
    634a602 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2021

  1. remove duplicate test and code clean up

    @dhiaayachi
    dhiaayachi committed Dec 1, 2021
    Copy the full SHA
    a8af0db View commit details
    Browse the repository at this point in the history

  2. add deprecation for Leader and Candidate fields

    @dhiaayachi
    dhiaayachi committed Dec 1, 2021
    Copy the full SHA
    d4932d0 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2021

  1. fix deprecation comments

    @dhiaayachi
    dhiaayachi committed Dec 2, 2021
    Copy the full SHA
    86c4d96 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2022

  1. Merge branch 'main' into noncluster-node-vote

    @dhiaayachi
    dhiaayachi committed Jan 5, 2022
    Copy the full SHA
    eff27ce View commit details
    Browse the repository at this point in the history

  2. check if node is voter instead if it's part of the cluster, nonVoter … 

    …should not have votes granted.
    @dhiaayachi
    dhiaayachi committed Jan 5, 2022
    Copy the full SHA
    4fa2eb0 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2022

  1. add deprecation notice for Leader() API.

    @dhiaayachi
    dhiaayachi committed Mar 7, 2022
    Copy the full SHA
    0e724f0 View commit details
    Browse the repository at this point in the history