Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comparison bug when comparing non-numeric prereleases #65

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix comparison bug when comparing non-numeric prereleases #65

wants to merge 1 commit into from

Commits on Oct 8, 2019

  1. Fix comparison bug when comparing non-numeric prereleases 

    Reference: hashicorp#61
This fixes a bug when comparing non-numeric prereleases of different set
sizes. Makes it so that X.Y-alpha is considered smaller than X.Y-alpha.beta
because a larger set of pre-release fields should have a higher
precedence than a smaller set if all of the preceding identifiers are
equal. Source: https://semver.org/#spec-item-11

When considering prerelease parts that are empty, use the other to
decide regardless if it is numeric or not. If our self part is empty
then the other part must be the larger set. If the other part is empty
then the self part must be the larger set.

Also fix and add a round out some additional test cases.
    Vicken Simonian committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    0dcf719 View commit details
    Browse the repository at this point in the history