Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comparison bug when comparing non-numeric prereleases #65

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vsimon
Copy link
Contributor

@vsimon vsimon commented Oct 8, 2019

Reference: #61
This fixes a bug when comparing non-numeric prereleases of different set
sizes. Makes it so that X.Y-alpha is considered smaller than X.Y-alpha.beta
because a larger set of pre-release fields should have a higher
precedence than a smaller set if all of the preceding identifiers are
equal. Source: https://semver.org/#spec-item-11

When considering prerelease parts that are empty, use the other to
decide regardless if it is numeric or not. If our self part is empty
then the other part must be the larger set. If the other part is empty
then the self part must be the larger set.

Also fix and add a round out some additional test cases.

Reference: hashicorp#61
This fixes a bug when comparing non-numeric prereleases of different set
sizes. Makes it so that X.Y-alpha is considered smaller than X.Y-alpha.beta
because a larger set of pre-release fields should have a higher
precedence than a smaller set if all of the preceding identifiers are
equal. Source: https://semver.org/#spec-item-11

When considering prerelease parts that are empty, use the other to
decide regardless if it is numeric or not. If our self part is empty
then the other part must be the larger set. If the other part is empty
then the self part must be the larger set.

Also fix and add a round out some additional test cases.
@hashicorp-cla
Copy link

hashicorp-cla commented Sep 9, 2021

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


Vicken Simonian seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants