Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use require to prevent a panic when dereferencing a nil pointer #458

Merged
merged 1 commit into from Jul 14, 2022
Merged

Use require to prevent a panic when dereferencing a nil pointer #458

merged 1 commit into from Jul 14, 2022

Commits on Jul 13, 2022

  1. Use require to prevent a panic when dereferencing a nil pointer 

    This is a workaround to simply prevent a panic from occurring. What's happening here
is the test is expecting two relationships to be included in the response, CurrentVersion and NewestVersion, but was
subject to the overall flakiness of our CI environment. This commit does not fix nor prevent the flakiness.

Why `require` and not `assert`? `require` makes the same calls as `assert` except it will terminate the execution
of a test upon failure. Using `assert` would still continue the test's execution, dereference a nil pointer, and boom panic!
    @sebasslash
    sebasslash committed Jul 13, 2022
    Copy the full SHA
    859701a View commit details
    Browse the repository at this point in the history