Use require
to prevent a panic when dereferencing a nil pointer
#458
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR stemmed from a panic from occurring during the execution of
TestPolicySetsRead/with_policy_set_version
.What's happening here is the test is expecting two relationships to be included in the response,
CurrentVersion
andNewestVersion
, but was subject to the overall flakiness of our CI environment. This PR does not fix nor prevent the flakiness.Note: Why
require
and notassert
?require
makes the same calls asassert
but it will terminate the execution of a test upon failure. Usingassert
would still continue the test's execution, dereference a nil pointer, and boom panic!Therefore this PR attempts to go through each integration test and swap
assert
forrequire
in instances where: