Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(requestinterception): fix font loading issue #1765

Merged
merged 4 commits into from Jul 10, 2021

Conversation

Androbin
Copy link
Contributor

@Androbin Androbin commented Jul 4, 2021

See upstream: puppeteer/puppeteer#7060

Fixes #1185

@kblok
Copy link
Member

kblok commented Jul 5, 2021

Nice job upstream @Androbin!

@kblok
Copy link
Member

kblok commented Jul 5, 2021

Can you check the builds here?

@kblok
Copy link
Member

kblok commented Jul 7, 2021

I think we are getting consistent fails here @Androbin

@Androbin
Copy link
Contributor Author

Androbin commented Jul 9, 2021

The PuppeteerLaunchTests.ShouldWorkWithNoDefaultArguments test failure on Linux is unrelated, see #1774

Copy link
Member

@kblok kblok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the hard work!

@kblok kblok merged commit b287219 into hardkoded:master Jul 10, 2021
@Androbin Androbin deleted the requestinterception branch July 10, 2021 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache is force disabled when intercept requests
2 participants