Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache is force disabled when intercept requests #1185

Closed
EtherealAO opened this issue Jun 22, 2019 · 4 comments · Fixed by #1765
Closed

Cache is force disabled when intercept requests #1185

EtherealAO opened this issue Jun 22, 2019 · 4 comments · Fixed by #1765
Labels
help wanted Upstream Change needed We need to wait for changes in Chromium or Puppeteer (Node.JS)

Comments

@EtherealAO
Copy link

Description

if i useawait page.SetRequestInterceptionAsync(true); , cache is force disabled(at least images is not caching). But I just want to intercept xhr requests not any request. Any method to enable caching while intercept requests?
@EtherealAO
Copy link
Author

resolved.
change lib/PuppeteerSharp/NetworkManager.cs => 'CacheDisabled = _userCacheDisabled || _protocolRequestInterceptionEnabled' (line 125) to 'CacheDisabled = _userCacheDisabled'

@kblok
Copy link
Member

kblok commented Jun 24, 2019

Asking upstream here puppeteer/puppeteer#4620

@kblok kblok added help wanted Upstream Change needed We need to wait for changes in Chromium or Puppeteer (Node.JS) labels Jun 24, 2019
@kblok kblok reopened this Jun 24, 2019
@Androbin
Copy link
Contributor

Androbin commented May 7, 2021

Update: puppeteer/puppeteer#4620 (comment)

@kblok kblok closed this as completed Jul 3, 2021
@Androbin
Copy link
Contributor

Androbin commented Jul 4, 2021

See #1765

@Androbin Androbin mentioned this issue Jul 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Upstream Change needed We need to wait for changes in Chromium or Puppeteer (Node.JS)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(requestinterception): fix font loading issue Androbin/puppeteer-sharp
3 participants
@kblok @Androbin @EtherealAO