Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for EOL Node.js versions #2007

Merged
merged 1 commit into from Sep 20, 2023
Merged

Drop support for EOL Node.js versions #2007

merged 1 commit into from Sep 20, 2023

Conversation

mohd-akram
Copy link
Contributor

This will be needed if ESM support is added and simplifies things.

jaylinski
jaylinski requested changes Sep 20, 2023
View reviewed changes
Copy link
Member

@jaylinski jaylinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the version here:

handlebars.js/package.json

Line 20 in 2afecb2

"node": ">=12"

.github/workflows/ci.yml Show resolved Hide resolved
@mohd-akram mohd-akram changed the title Drop EOL Node.js versions from CI Drop support for EOL Node.js versions Sep 20, 2023
@jaylinski jaylinski merged commit ce1f2ab into handlebars-lang:master Sep 20, 2023
7 checks passed
@jaylinski
Copy link
Member

Thanks!

@mohd-akram mohd-akram deleted the update-ci branch September 20, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaylinski jaylinski jaylinski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mohd-akram @jaylinski