Skip to content

Commit

Permalink
Drop support for EOL Node.js versions
Browse files Browse the repository at this point in the history
  • Loading branch information
mohd-akram authored and jaylinski committed Sep 20, 2023
1 parent 2afecb2 commit ce1f2ab
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 28 deletions.
27 changes: 1 addition & 26 deletions .github/workflows/ci.yml
Expand Up @@ -25,31 +25,6 @@ jobs:
- name: Lint
run: npm run lint

dependencies:
name: Test (dependencies)
runs-on: 'ubuntu-latest'
steps:
- name: Checkout
uses: actions/checkout@v2

- name: Setup Node.js
uses: actions/setup-node@v2
with:
# Node 14 ships with npm v6, which doesn't install peer-dependencies by default.
# Starting with npm v7 (which is shipped with Node >= 16), peer-dependencies are
# automatically installed. So this test (check for unmet peer-dependencies) only
# works with Node <= 14.
node-version: '14'

# Simulate an installation by a dependent package
- name: Install dependencies
run: |
rm package-lock.json
npm install --production
- name: Check dependency tree
run: npm ls

test:
name: Test (Node)
runs-on: ${{ matrix.operating-system }}
Expand All @@ -58,7 +33,7 @@ jobs:
matrix:
operating-system: ['ubuntu-latest', 'windows-latest']
# https://nodejs.org/en/about/releases/
node-version: ['12', '14', '16', '18', '20']
node-version: ['18', '20']

steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -17,7 +17,7 @@
"license": "MIT",
"readmeFilename": "README.markdown",
"engines": {
"node": ">=12"
"node": ">=18"
},
"dependencies": {
"@handlebars/parser": "^2.1.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/multi-nodejs-test/test.sh
Expand Up @@ -14,7 +14,7 @@ cd "$( dirname "$( readlink -f "$0" )" )" || exit 1
unset npm_config_prefix

echo "Handlebars should be able to run in various versions of NodeJS"
for node_version_to_test in 12 14 16 18; do
for node_version_to_test in 18 20; do

rm -rf target node_modules package-lock.json
mkdir target
Expand Down

0 comments on commit ce1f2ab

Please sign in to comment.