Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix progress parameter type compatibility between cURL and StreamHandler #2936

Merged
merged 1 commit into from Oct 7, 2021
Merged

Fix progress parameter type compatibility between cURL and StreamHandler #2936

merged 1 commit into from Oct 7, 2021

Commits on Sep 28, 2021

  1. Fix progress parameter type compatibility between cURL and StreamHandler 

    Unknown values of the progress called are filled with `0` by cURL and in fact
the `CURLOPT_PROGRESSFUNCTION` parameters are explicitly typed `int` in
CurlFactory.

StreamHandler always provided `null` as the upload progress, because the
progress is not known there. Adjust this to `0` for consistent behavior.
    @TimWolla
    TimWolla committed Sep 28, 2021
    Copy the full SHA
    209650c View commit details
    Browse the repository at this point in the history