Fix progress parameter type compatibility between cURL and StreamHandler #2936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unknown values of the progress called are filled with `0` by cURL and in fact the `CURLOPT_PROGRESSFUNCTION` parameters are explicitly typed `int` in CurlFactory. StreamHandler always provided `null` as the upload progress, because the progress is not known there. Adjust this to `0` for consistent behavior.
GrahamCampbell
approved these changes
Oct 7, 2021
|
6.4.0 has now been released, including this fix. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unknown values of the progress called are filled with
0by cURL and in factthe
CURLOPT_PROGRESSFUNCTIONparameters are explicitly typedintinCurlFactory.
StreamHandler always provided
nullas the upload progress, because theprogress is not known there. Adjust this to
0for consistent behavior.