Ensure link can be read before checking it is a directory (PHPStan Error)

[davidgrayston]

Fixes PHPStan error affecting checks on open PRs

 ------ ------------------------------------------------------------------------------- 
  Line   Handler/CurlFactory.php                                                        
 ------ ------------------------------------------------------------------------------- 
  366    Parameter #1 $filename of function is_dir expects string, string|false given.  
 ------ ------------------------------------------------------------------------------- 

Happy to close this PR if you'd prefer to ignore the PHPStan error

I'll remove this fix from #2589 if this is merged (or if this error is ignored in a separate PR)

Fixed

• Ensure link can be read before checking it is a directory

[davidgrayston]

Just noticed you closed #2637 in favour of ignoring the error - please confirm (or merge the change to ignore) and I'll close this PR

[gmponos]

Although I don't like the syntax here.. it seems like a solution for now :)

thank you.

[GrahamCampbell]

This PR should target the 6.5 branch.

[gmponos]

This PR should target the 6.5 branch.

IMHO maintaining both branches has huge cost. For now I think we should target to 6.5 what is necessary for the ICU fixes.. for me this is fine targeting master and we can add an ignore in baseline of 6.5 if a PR needs to get going

[gmponos]

Thank you.