Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid PHPStan error #2637

Closed
wants to merge 1 commit into from
Closed

Avoid PHPStan error #2637

wants to merge 1 commit into from

Conversation

guilliamxavier
Copy link
Contributor

@GrahamCampbell
Copy link
Member

👎 It should not be cast to a string. We want the code to crash if the returned value is not a string.

@GrahamCampbell
Copy link
Member

This PR is replaced by https://github.com/guzzle/guzzle/pull/2626/files anyway, which adds this case to the baseline errors file.

@guilliamxavier
Copy link
Contributor Author

guilliamxavier commented May 13, 2020 •
edited

Ok, please merge #2626 soon ;)
Or maybe better split it as the error is unrelated...

@guilliamxavier guilliamxavier deleted the patch-3 branch May 13, 2020 11:55
@davidgrayston davidgrayston mentioned this pull request May 13, 2020
Merged
@guilliamxavier
Copy link
Contributor Author

FTR: different approaches have been merged in #2638 (for 6.5) and #2639 (for master)

@gmponos
Copy link
Member

gmponos commented May 17, 2020

FTR: different approaches have been merged in #2638 (for 6.5) and #2639 (for master)

Yea I know.. Personally speaking I want to keep the 6.5 with the minimum changes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@guilliamxavier @GrahamCampbell @gmponos