Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RetryMiddleware default exponential delay #2132

Merged
merged 4 commits into from Dec 7, 2019
Merged

Fix RetryMiddleware default exponential delay #2132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c2b0f35
Fix RetryMiddleware::exponentialDelay by making it return milliseconds
dluces Aug 28, 2018
de9c8bd
Fix RetryMiddleware::exponentialDelay by making it return milliseconds
dluces Aug 28, 2018
cbf6130
Fix exponentialDelay int casting
dluces Aug 29, 2018
04851a2
Added comment
Nyholm Dec 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/RetryMiddleware.php
View file
Open in desktop
Expand Up @@ -47,11 +47,11 @@ public function __construct(
*
* @param int $retries
*
* @return int
* @return int milliseconds.
*/
public static function exponentialDelay($retries)
Nyholm marked this conversation as resolved.
Show resolved Hide resolved
{
return (int) pow(2, $retries - 1);
return (int) pow(2, $retries - 1) * 1000;
}

/**
Expand Down
8 changes: 4 additions & 4 deletions tests/RetryMiddlewareTest.php
View file
Open in desktop
Expand Up @@ -73,9 +73,9 @@ public function testCanRetryExceptions()
public function testBackoffCalculateDelay()
{
self::assertSame(0, RetryMiddleware::exponentialDelay(0));
self::assertSame(1, RetryMiddleware::exponentialDelay(1));
self::assertSame(2, RetryMiddleware::exponentialDelay(2));
self::assertSame(4, RetryMiddleware::exponentialDelay(3));
self::assertSame(8, RetryMiddleware::exponentialDelay(4));
self::assertSame(1000, RetryMiddleware::exponentialDelay(1));
self::assertSame(2000, RetryMiddleware::exponentialDelay(2));
self::assertSame(4000, RetryMiddleware::exponentialDelay(3));
self::assertSame(8000, RetryMiddleware::exponentialDelay(4));
}
}